search

Macaulay2 / M2

The primary source code repository for Macaulay2, a system for computing in commutative algebra, algebraic geometry and related fields.
https://macaulay2.com
347 stars 231 forks source link

FunctionFieldDesingularization creates files #2271

Closed DanGrayson closed 3 years ago

DanGrayson commented 3 years ago

The tests in the package FunctionFieldDesingularization create files that end up cluttering the build tree. Since the files are not used after being created, we might as well change lines such as fout := openOut "Cutkosky7.35.1" to fout := openOut "/dev/null". (The files created during example generation are not an issue, because they are put into a temporary directory that is deleted later.)

@Douglas-Leonard

Douglas-Leonard commented 3 years ago

I just want users to have a lot of examples to work from and know that the code has been tested on lots of examples from the literature. So suit yourself in changing it; or tell me what to exactly what to change, as my assumption from what you said would be to replace every occurrence of a file name such as "foo" with "/device/null", but then add a comment that one could replace the "/device/null" in the test by any file name such as "foo".

(An alternative could be to have the output file as an option; but then I would have to document that, and I hate writing the documentation).

Doug

From: Daniel R. Grayson @.> Sent: Wednesday, October 27, 2021 9:44 AM To: Macaulay2/M2 @.> Cc: Douglas Leonard @.>; Mention @.> Subject: [EXT] [Macaulay2/M2] FunctionFieldDesingularization creates files (Issue #2271)

CAUTION: Email Originated Outside of Auburn.

The tests in the package FunctionFieldDesingularization create files that end up cluttering the build tree. Since the files are not used after being created, we might as well change lines such as fout := openOut "Cutkosky7.35.1" to fout := openOut "/dev/null". (The files created during example generation are not an issue, because they are put into a temporary directory that is deleted later.)

@Douglas-Leonardhttps://github.com/Douglas-Leonard

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/Macaulay2/M2/issues/2271, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABFN3FFHJCY74J2YE5PX2TLUJAF3XANCNFSM5G2RJDMA. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

DanGrayson commented 3 years ago

The examples in the documentation are fine -- I'll go ahead and change the tests, which users don't normally see.

DanGrayson commented 3 years ago

done in commit 0bdfd90a815ba9d3054ed905b87b4752e3443a1d