search

Macaulay2 / M2

The primary source code repository for Macaulay2, a system for computing in commutative algebra, algebraic geometry and related fields.
https://macaulay2.com
343 stars 230 forks source link

Add an mpfi patch #3294

Closed d-torrance closed 3 months ago

d-torrance commented 3 months ago

I just built a Fedora 40 package for 1.24.05 and posted it to the website. I took some notes on the process and updated INSTALL accordingly. One of the few dependencies without an existing Fedora package is mpfi, and it needed a patch (cherry-picked from upstream's git repo) to compile with the latest gcc.

I also built a Rocky Linux 9.4 (compatible with RHEL 9.4) package, but didn't think to take notes about what I did until afterwards... There was lots of fiddling with FFLAS-FFPACK flags!

d-torrance commented 3 months ago

I canceled the builds (meant to skip them but forgot) since this PR doesn't affect them. We're just editing a text file and patching a library that GitHub doesn't build.

mahrud commented 3 months ago

Would it be better if the building instructions were on the wiki and we just had links to those pages in a single INSTALL.md file in git? (Thinking of also moving the CMake instructions to wiki)

d-torrance commented 3 months ago

Sounds good to me!

d-torrance commented 3 months ago

I went ahead and added some links on the wiki page for installing M2 in various ways. I started the Linux instructions and plan on working on the autotools ones soon.

d-torrance commented 3 months ago

I removed the INSTALL changes from this PR -- it's now on the wiki (which still needs some formatting, but it's in progress.) It's now just the mpir patch.

Still skipping the GitHub builds since they don't build mpir.

jamesjer commented 3 months ago

I don't understand. Fedora has had an mpfi package since 2008. The linked patch has been applied to it, which makes sense since I am both the author of the patch and the maintainer of the Fedora mpfi package. :-)

d-torrance commented 3 months ago

Weird -- maybe I fat-fingered something when I tried to install it. I'll try playing around with it again.

Regardless, we should include this patch for anyone building Macaulay2 on a system that doesn't have an mpfi package.

d-torrance commented 3 months ago

Found the mpfi-devel package! Not sure how I missed it...

d-torrance commented 3 months ago

@DanGrayson -- is this okay to merge? As I mentioned above, I skipped the builds because the GitHub builds use packaged versions of mpfi and this patch wouldn't be tested.

DanGrayson commented 3 months ago

I don't see any test runs.

d-torrance commented 3 months ago

Because I skipped them. As I explained above, this patch wouldn't be tested since we don't build mpfi as part of the github builds.