Closed mahrud closed 1 month ago
I hope the last commit fixed the autotools issue, but if it didn't work, @d-torrance do you mind looking into what's missing?
Figured it out! We need to use AC_SUBST
instead of AC_DEFINE
now.
Apparently neither cmake nor autotools have been detecting the git description and branch correctly on development when building on GitHub. I don't know where this started, but on autotools we've just been getting:
configure: configuring Macaulay2 version 1.24.05
...
configure: with GIT_DESCRIPTION = release-1.24.05
configure: with GIT_BRANCH =
And on cmake:
M2 version = 1.24.05
Git description =
Git branch =
It seems like it's because github uses a shallow checkout, which doesn't pull tags. This makes sense and I don't necessarily think we should change it (though for future reference, here is how one would change it: https://github.com/actions/checkout#fetch-all-history-for-all-tags-and-branches)
Finally closes #3250, which has been such a pain ...
The main difficulty was rearranging startup.m2 to:
all before the version is printed.
If
version.m2
is not found, for whatever reason, we get:The "-bin" indicates that this is the version stored in the binary only.