Macaulay2 / M2

The primary source code repository for Macaulay2, a system for computing in commutative algebra, algebraic geometry and related fields.
https://macaulay2.com
333 stars 228 forks source link

comparison of ideals #660

Open DanGrayson opened 6 years ago

DanGrayson commented 6 years ago

For ideals I==J it might be faster to compare gb's rather than to perform all the reductions performed by isSubset(I,J) and isSubset(J,I).

Why is the code here commented out?:

i41 : code (symbol ==, Ideal, Ideal)

o41 = -- code for method: Ideal == Ideal
      /Applications/Macaulay2-1.10/share/Macaulay2/Core/matrix1.m2:547:25-554:40: --source code:
      Ideal == Ideal := (I,J) -> (
           samering(I,J);
           ( generators I == generators J or 
                -- if isHomogeneous I and isHomogeneous J  -- can be removed later
                -- then gb I == gb J 
                -- else
                isSubset(I,J) and isSubset(J,I)         -- can be removed later
                ))

It's been that way since 1998.

eisenbud commented 6 years ago

and why wouldn't gens gb I == gens gb J work for inhomogeneous ideals too?

David

David Eisenbud Director, Mathematical Sciences Research Institute; and Professor of Mathematics,University of California, Berkeley www.msri.org/~de

On Jul 27, 2017, at 5:00 PM, Daniel R. Grayson notifications@github.com wrote:

For ideals I==J it might be faster to compare gb's rather than to perform all the reductions performed by isSubset(I,J) and isSubset(J,I).

Why is the code here commented out?:

i41 : code (symbol ==, Ideal, Ideal)

o41 = -- code for method: Ideal == Ideal /Applications/Macaulay2-1.10/share/Macaulay2/Core/matrix1.m2:547:25-554:40: --source code: Ideal == Ideal := (I,J) -> ( samering(I,J); ( generators I == generators J or -- if isHomogeneous I and isHomogeneous J -- can be removed later -- then gb I == gb J -- else isSubset(I,J) and isSubset(J,I) -- can be removed later )) It's been that way since 1998.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Macaulay2/M2/issues/660, or mute the thread https://github.com/notifications/unsubscribe-auth/AD1LDe2nQU3YUTJJ-HBZPpJe4c0hXC_Rks5sSKYCgaJpZM4OlaSf.

DanGrayson commented 6 years ago

Indeed.

But we should make sure it's not a "local" ordering.