Macaulay2 / Workshop-2023-Minneapolis

Collaboration area for the Macaulay2 workshop in Minneapolis, 2023
https://macaulay2.github.io/Workshop-2023-Minneapolis/
8 stars 2 forks source link

Bug in AntiDiagInit documentation #20

Closed TheGrateSalmon closed 1 year ago

TheGrateSalmon commented 1 year ago

There is something wrong in commit ae5a953 that causes installPackage "MatrixSchubert" to have a fatal error. Here is the traceback

installPackage "MatrixSchubert"
 -- warning: symbol "isCM" in Depth.Dictionary is shadowed by a symbol in Graphs.Dictionary
 --   use the synonym Depth$isCM
MatrixSchubert/Documentation/MatrixSchubertConstructionsDOC.m2:111:1:(3):[16]: error: unmatched @ near line #129:
        UL {
MatrixSchubert/Documentation/MatrixSchubertConstructionsDOC.m2:111:1:(3):[16]: --entering debugger (type help to see debugger commands)
MatrixSchubert/Documentation/MatrixSchubertConstructionsDOC.m2:111:1-111:1: --source code:
doc ///

and the referenced doc node

doc ///
    Key
        (antiDiagInit, List)
        (antiDiagInit, Matrix)
        antiDiagInit
    Headline
        Computes the (unique) antidiagonal initial ideal of an ASM ideal
    Usage
        antiDiagInit(w)
        antiDiagInit(A)
    Inputs
         w:List
        or {\tt A} is a @TO Matrix@
    Description
        Text
     Let Z = (z_(i,j)) be a generic matrix and R=k[Z] is a polynomial ring in the entries of Z over the ring k.  We call a term order 
     on R antidiagonal if the lead term of the determinant of each submatrix Z' of Z is the product of terms along the antidiagonal 
     of Z'. 

     This method relies on these theorems.  It computes the antidiagonal initial ideal of an alternating sign matrix ideal by directly forming 
     the ideal of the lead terms of the Fulton generators.  @UL {
        {"[KM05]: Knutson and Miller, Gröbner geometry of Schubert polynomials (see ", arXiv "0110058", ")."},}@ tells us that the Fulton generators of each 
     Schubert determinantal ideal form a Gröbner basis, a result extended to alternating sign matrix ideals by  @UL {
        {"[Knu]: Knutson, Frobenius splitting, point-counting, and degeneration (see ", arXiv "0911.4941", ")."},
        }@ and by @UL {
        {"[Wei]: Weigandt, Prism tableaux for alternating sign matrix varieties (see ", arXiv "1708.07236", ")."},
        }@.

     Example
     schubertDetIdeal({1,3,2})
     schubertDetIdeal(matrix{{0,0,0,1},{0,1,0,0},{1,-1,1,0},{0,1,0,0}})

///
jmcdonough98 commented 1 year ago

this is fixed as of 973c179

The issue was that the return of antiDiagInit was given as the function monomialIdeal and not the data type MonomialIdeal.

Also there were some syntax issues with the actual documentation but those have also been fixed.