search

Macchina-CLI / libmacchina

A library providing access to all sorts of system information.
https://crates.io/crates/libmacchina
MIT License
68 stars 20 forks source link

Improve CI #104

Closed FantasyTeddy closed 2 years ago

FantasyTeddy commented 2 years ago

I'm trying to get the build pipeline to pass. The following changes are made:

Currently the "Linux (aarch64-unknown-linux-gnu)" build job is still failing. What is the purpose of this configuration? Is this for OpenWrt?

grtcdr commented 2 years ago

Thanks for adding FreeBSD to the list, I tried doing this before and gave up.

As for the aarch64 target, that one's for OpenWrt, which fails for some reason but the openwrt module makes no use of which so we can avoid running it when the openwrt feature is enabled.

FantasyTeddy commented 2 years ago

Are you sure that the aarch64-unknown-linux-gnu build is actually building with the openwrt feature? If so, can you explain how this works?

grtcdr commented 2 years ago

At the moment, the openwrt feature isn't being enabled for aarch64, I'll look into how we can do that...

FantasyTeddy commented 2 years ago

I tried to add proper support for OpenWrt in the CI pipeline in my last 2 commits. What do you think?

grtcdr commented 2 years ago

Looks great!

grtcdr commented 2 years ago

Looks like we're good to merge, shall I?

FantasyTeddy commented 2 years ago

Sure, I think this will give us more confidence when refactoring things that affect multiple targets.