Improve CI workflow - Githubissues

Macchina-CLI / libmacchina

A library providing access to all sorts of system information.

https://crates.io/crates/libmacchina

MIT License

62 stars 20 forks source link

Improve CI workflow #169

Closed FantasyTeddy closed 3 months ago

FantasyTeddy commented 4 months ago

These are the same changes already applied to macchina: Macchina-CLI/macchina#311 & Macchina-CLI/macchina#313

Replacement of actions-rs with dtolnay/rust-toolchain and explicit calls to the respective cargo/cross commands.
Extracting the cargo fmt and cargo clippy steps into their own jobs.
Fail clippy on warnings (required some minor code changes).

grtcdr commented 4 months ago

Hey there, thank you so much for the pull request. :)

Regarding the job approach, to me it seems inefficient splitting what could remain a simple step into two jobs that duplicate two steps: checking out the repository and initializing the toolchain. In total, this results in three separate checkouts and toolchain installations.

FantasyTeddy commented 4 months ago

Okay, I see your point. I merged the two jobs into one.

grtcdr commented 3 months ago

Thank you @FantasyTeddy!