Refactoring of ProductReadout

Macchina-CLI / libmacchina

A library providing access to all sorts of system information.

https://crates.io/crates/libmacchina

MIT License

68 stars 20 forks source link

Refactoring of ProductReadout #96

Closed FantasyTeddy closed 3 years ago

FantasyTeddy commented 3 years ago

This is the refactoring mentioned in #95.

Summary:

Removes version() and name() from ProductReadout
Fixes documentation for ProductReadout to not be mistaken for operating system information
Fix the implementation for macOS & Windows that reported OS information instead of device information

⚠ Important: Please double check the implementation for anything but Windows, because I don't have a running system of those types.

grtcdr commented 3 years ago

Looks good to me! We'll have to test out different configurations to see how this new change will look out in the wild.

grtcdr commented 3 years ago

I'll test a couple of my VMs, along with my native Linux box.

EDIT: Works great on my machine, couldn't test out one of my VMs due to a compilation issue on my end.

We can safely assume this works on NetBSD as the implementation of ProductReadout is nearly identical to Linux, so if there's any issues.

EDIT 2: I'm not going to assume this time, we'll merge this change and roll it out in v6 and see how things go from there, v6 is not ready yet, so this should give us enough time to find any weirdness (if there is any).

FantasyTeddy commented 3 years ago

Great, thank you for testing it!

grtcdr commented 3 years ago

No problem :)