search

Macchina-CLI / macchina

A system information frontend with an emphasis on performance.
https://crates.io/crates/macchina
MIT License
1.49k stars 52 forks source link

Fix: dirs is not a iterator #189

Closed sak96 closed 3 years ago

sak96 commented 3 years ago

Fixes: #191

grtcdr commented 3 years ago

Any particular reason why I don't get this error?

sak96 commented 3 years ago

More info #191 rustc: 2021-05-09 or 1.52.1 Feel free to reject it if that is not suppose to be supported.

sak96 commented 3 years ago

@grtcdr

can be reproduced using:

docker run -it -v $(pwd):/mnt -w /mnt rust:1.52.1  cargo build
sak96 commented 3 years ago

also did not know that you are from MARS :+1:

grtcdr commented 3 years ago

Feel free to reject it if that is not suppose to be supported.

Well, most of us run the latest and greatest Rust compiler. Are you unable to upgrade?

also did not know that you are from MARS

:alien:

sak96 commented 3 years ago

I was able to update in one of the machines. other one uses ubuntu repositories which has older version of rustc. but there i could manually update the registry code. in worst case i can install directly from my git repo.

123marvin123 commented 3 years ago

I think this should be fine for merging, what do you think @grtcdr ?

grtcdr commented 3 years ago

Although I don't plan on supporting older versions of rustc, I'll go ahead and merge it.