Improve CI workflow - Githubissues

Macchina-CLI / macchina

A system information frontend with an emphasis on performance.

https://crates.io/crates/macchina

MIT License

1.24k stars 47 forks source link

Closed FantasyTeddy closed 1 week ago

FantasyTeddy commented 2 months ago

This is the implementation of the changes discussed in #311:

Extracting the cargo fmt and cargo clippy steps into their own jobs.
- @grtcdr: What do you think? Is this OK, or should we combine the two jobs?
Fail clippy on warnings (required some minor code changes).
Execute the "Test" and "Doctor" change on all platforms that support it.

Additionally, I removed the strip variable from the matrix, because it was never used.

FantasyTeddy commented 2 months ago

The "GNU/Linux x86_64 (x86_64-unknown-linux-gnu)" job seems to fail the "Doctor" stage because of an actual bug in libmacchina: https://github.com/Macchina-CLI/libmacchina/blob/main/src/linux/mod.rs#L831

grtcdr commented 1 week ago

This looks good to me, let's merge :)