Mach5 / supersonic

Open-source web-based media streamer and jukebox fork of Subsonic. Supports MP3, OGG, AAC and other streamable audio and video formats. Runs on Windows, GNU/Linux and Mac using Java.
241 stars 60 forks source link

CSS & JS Compression #33

Closed nicolasberens closed 12 years ago

nicolasberens commented 12 years ago

Integrate the YUI Compressor into Maven http://alchim.sourceforge.net/yuicompressor-maven-plugin/

I'm going to do that, and this ticket is just a placeholder so im rembered to this and nobody else does it ;-)

porkcharsui commented 12 years ago

This is definitely a quick feature change that will have good benefit for end users of the WebUI. I personally have implemented @alexo/wro4j and found it to be a quick drop with lots of extra cool features (CSS pre processors, JS lint etc)

http://code.google.com/p/wro4j/

nicolasberens commented 12 years ago

at the moment im using the YUI Compressor, simply because you get it running with 10 lines of code in the pom.xml

wait a minute, i create a pull request

nicolasberens commented 12 years ago

and there it is, the pull request #35 https://github.com/Mach5/supersonic/pull/35

nicolasberens commented 12 years ago

after messing up my git branch, i think it would be easier when someone takes the pom.xml from my repo and inserts it into the supersonic repo, https://github.com/rtznprmpftl/supersonic/blob/master/pom.xml

timoreimann commented 12 years ago

I'm on it.

timoreimann commented 12 years ago

@rtznprmpftl, would you mind taking a quick look at the newly created _yuicompressor branch under

https://github.com/Mach5/supersonic/tree/yui_compressor

and let me know I did things right?

It covers two commits: 1a53ab8 which represents your changes (namely adding YUI compressor); and fc3bfde which is a minor on-top change removing the version specification from the plugin configuration to get rid of a Maven warning.

Given your acknowledgement I will merge the branch into master.

nicolasberens commented 12 years ago

seems ok

timoreimann commented 12 years ago

Thanks a lot -- and sorry again for any confusion I've created.

Approved, merged, and closed.