search

Mach5 / supersonic

Open-source web-based media streamer and jukebox fork of Subsonic. Supports MP3, OGG, AAC and other streamable audio and video formats. Runs on Windows, GNU/Linux and Mac using Java.
226 stars 61 forks source link

when creating sort name ignore non-alphanumeric and convert '_' to space #37

Closed trapexit closed 12 years ago

trapexit commented 12 years ago

This is to address issue #24. When creating a sort name it replaces all Unicode characters that are not letters or numbers with spaces and then trims. This accounts for artists with punctuation in their name. It may be worth replacing umlauted and other special versions with their plain ascii version. I don't know enough about other languages to say if that's a reasonable behavior.

porkcharsui commented 12 years ago

Accepted in a30ce387

porkcharsui commented 12 years ago

CI is still reporting MVN errors post revert. http://travis-ci.org/#!/Mach5/supersonic/builds/1003401

timoreimann commented 12 years ago

@porkcharsui, I think you picked the wrong build (no. 67). The reverting build is at http://travis-ci.org/#!/Mach5/supersonic/builds/1007653 (no. 68).

Working on a real fix right now.

timoreimann commented 12 years ago

CI repaired with build #71.

porkcharsui commented 12 years ago

Thanks @timoreimann. I appreciate you driving the unit test effort. I'll make note to check in new unit tests with any additional features or functionality I commit.