search

Mach5 / supersonic

Open-source web-based media streamer and jukebox fork of Subsonic. Supports MP3, OGG, AAC and other streamable audio and video formats. Runs on Windows, GNU/Linux and Mac using Java.
226 stars 61 forks source link

RangeOutputstream is missing 1 byte #47

Open Der-Jan opened 12 years ago

Der-Jan commented 12 years ago

When playing around with HTML5 Audio tag as a replacement for JWPlayer, my iPad never started playing. Usign Wireshark I saw, it is sending a Range: bytes=0-1 HTTP header. Subsonic only sent back byte 0 (instead of byte 0 and byte 1), so the iPad was waiting for the second byte.

timoreimann commented 12 years ago

Do I understand commit 7171f4d right that it completely removes JWPlayer? If so, what's the reason for that? Shouldn't your Range handling modification (commit 63da509) alone fix the bug you are describing?

Der-Jan commented 12 years ago

The bug should be fixed with commit 63da509 - removing JWPlayer is not directly related - I want to be able to use my iPhone to play the music without an app. JWPlayer (in HTML5 mode) doesn't seem to be a good option for this, since it's using <video> tag instead of the <audio>.

timoreimann commented 12 years ago

I feel somewhat reluctant to accept the pull request yet if one of the commits isn't needed to fix the bug and removes JWPlayer from the code base. Admittedly, my knowledge about HTML5 audio/video playing is limited, so I need to ask you this directly: What's the implication of removing JWPlayer? Will it break compatibility with certain browsers?

Additionally, issue #32 is dealing with introducing HTML5 playback as well. @porkcharsui: You're more involved with the subject than I am. What's your opinion on this?

porkcharsui commented 12 years ago

I'll review this tomorrow since I need to evaluate the change's impacts with media playback. The RangeOutputStream fix is a good find!

Eventually I want to replace the UI as a whole (player, UI key bindings, etc) while allowing fall back to the "Subsonic" frame interface if needed.

timoreimann commented 12 years ago

@porkcharsui, I took the liberty to assign this issue to you for the moment because you seem most qualified to review the impact of the pull request.