MachUpskillingFY17 / JabbR-Core

Modern edition of JabbR chat client using .NET Core
MIT License
7 stars 8 forks source link

Account controller integration #266

Closed jcocchi closed 7 years ago

jcocchi commented 7 years ago

Use Cases to Test:

Try to enter invalid entries in each form and verify all validation messages are working properly. Register a couple users and verify old messages from other users display in the room.

ashanhol commented 7 years ago
gcrev93 commented 7 years ago
gcrev93 commented 7 years ago

Just retested and Login works :) Looking into the nav bar now

kevinleung23 commented 7 years ago

Bug

However, logging in with preexisting account (from another project session) works.

Works

ashanhol commented 7 years ago

Facebook login works, normal login works, login/logout works (except the logout button in Account?), messages persist across logins. Things that do not work:

Forgot password error:

An error occurred during the compilation of a resource required to process this request. Please review the following specific error details and modify your source code appropriately.

Generated Code

Type expected
        #pragma warning restore 1998
Type expected
        #pragma warning restore 1998
Type expected
        #pragma warning restore 1998
The type or namespace name 'ForgotPasswordViewModel' could not be found (are you missing a using directive or an assembly reference?)
    public class _Views_Account_ForgotPassword_cshtml : Microsoft.AspNetCore.Mvc.Razor.RazorPage<ForgotPasswordViewModel>
The type or namespace name 'ForgotPasswordViewModel' could not be found (are you missing a using directive or an assembly reference?)
        public Microsoft.AspNetCore.Mvc.Rendering.IHtmlHelper<ForgotPasswordViewModel> Html { get; private set; }
The type or namespace name 'ForgotPasswordViewModel' could not be found (are you missing a using directive or an assembly reference?)
        #pragma warning restore 1998
The type or namespace name 'ForgotPasswordViewModel' could not be found (are you missing a using directive or an assembly reference?)
        #pragma warning restore 1998
The type or namespace name 'ForgotPasswordViewModel' could not be found (are you missing a using directive or an assembly reference?)
        #pragma warning restore 1998

/Views/Account/ForgotPassword.cshtml

The type or namespace name 'Jabbr_Core' could not be found (are you missing a using directive or an assembly reference?)
@using Jabbr_Core.ViewModels;
heatherbshapiro commented 7 years ago

updated forgotpassword.cshtml so the link should be working now for forgot password.

kevinleung23 commented 7 years ago

Refactored ForgotPassword.cshrml and ForgotPasswordComfirmation.cshtml to match layout. UI changes.

ashanhol commented 7 years ago

Ok. Then only issue #267 remains but can be dealt with after. Seems like things work!!!!! O_O :shipit:

kevinleung23 commented 7 years ago

I only see issues #267 and #129 which can be addressed in 0.6 :shipit: