Integrate Entity Framework

adamtuliper commented 8 years ago

Uber issue for integrating entity framework

[x] #4 Add EF support into project - binaries and bootstrap code only
[x] #21 Refactor RemoveUserRoom from PersistedRepository
[x] #22 Create standalone EF Core console app with Jabbr Schema
[x] #25 Integrate IJabbrRepository and PersistedRepository
[x] #26 Add EF bits from console app into Jabbr Core
[x] #39 Compare schemas between Jabbr 1 and new EF Core generated db
[x] #49 Move IJabbrRepository and InMemoryRepository over to Jabbr-Core
[x] #55 Jgc/ef integration
[x] #57 Create Jabbr-Core.Data and migrate all EF into it
[x] #66 Refactor JabbrContextModelSnapshot to reflect new table names and model namespaces
[ ] #67 Update models to add in missing properties from old Jabbr
[x] #71 Refactor UserData.cs out of the root
[x] #93 Refactor entity property names in the context for consistency
[ ] #96 Analyze logs for index tuning
[ ] #97 Refactor In-mem repository to work with EF
[x] #100 Refactor JabbR-Core files to work with the new models
[ ] #125 .NET Core In Memory database error with JabbrContext
[ ] #132 Write Tests for Services.RepositoryExtensions.cs
[ ] #152 Tests for online users yields inconsistent results for RepositoryExtensionsTests.cs

JamesEarle commented 8 years ago

Removing closed issues / merged PRs from that list.

ashanhol commented 7 years ago

PR #145 has number of fixes: "Merging the new models, changing Jabbr-Core code to use the new models, database migrations, and testing. Fixes #21 #25 #66 #67 #93 #100 #121 #132"

JamesEarle commented 7 years ago

Some of the issues in the above are marked as completed in the list but are still open - are we waiting until we get their relevant PRs merged before closing?

adamtuliper commented 7 years ago

Ya, they shouldn't be closed until merged. They should be autoclosed if referenced in pr.

On Oct 7, 2016 5:32 PM, "James Earle" notifications@github.com wrote:

Some of the issues in the above are marked as completed in the list but are still open - are we waiting until we get their relevant PRs merged before closing?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/MachUpskillingFY17/JabbR-Core/issues/56#issuecomment-252390126, or mute the thread https://github.com/notifications/unsubscribe-auth/ABqPDSmdEUa8YF8PAOTFLFQhvUAypjyJks5qxuSXgaJpZM4J3IsV .

JamesEarle commented 7 years ago

Oh really? They weren't auto closing before, is there some way you need to reference them specifically?

MachUpskillingFY17 / JabbR-Core

Integrate Entity Framework #56