search

Machine-Mavericks / romi-examples

Additional Romi Example Projects
0 stars 0 forks source link

make robot move forward and to the right #12

Open gbuckholtz opened 3 years ago

gbuckholtz commented 3 years ago

1 meter forward and the 25 cm to the right

gbuckholtz commented 3 years ago

Hi! There was a small problem with the code that you committed to the main branch. First, it is better if you create a branch for your work and then make a pull request to get the code in the main branch. It allows us to get another pair of eyes on the code before it goes into the main branch.

    m_chooser.setDefaultOption("Ramsete Trajectory", generateRamseteCommand());
    m_chooser.addOption("ZigZag Trajectory", generateZigZagCommand());
    //
    //----   copy this command and paste it below the comment ----
    //----   replace {yourName} with the name of the function you just created ---
    //
    // m_chooser.addOption("{yourName} Trajectory", generate{yourname}Command());
    m_chooser.addOption("{yourName} Trajectory", generateForwardRightCommand());
    m_chooser.addOption("Auto Routine Distance", new AutonomousDistance(m_drivetrain));
    m_chooser.addOption("Auto Routine Time", new AutonomousTime(m_drivetrain));
    m_chooser.addOption("BackLeft Trajectory", generateBackLeftCommand());
    m_chooser.addOption("BackDiagonalRight Trajectory", generateBackDiagonalRightCommand());

In your addOption command you didn't put the actual name of your trajectory. It will show up in the smart dashboard as '{yourName} Trajectory' .

For practice, can you make a branch and make a pull request for this fix? Thanks!

P.S. I have created a 'bug' for this fix: https://github.com/Machine-Mavericks/romi-examples/issues/17