search

MachineLearningLifeScience / poli

Protein Objectives Library
MIT License
12 stars 1 forks source link

Registering multiple observers #174

Closed SimonBartels closed 1 week ago

SimonBartels commented 3 months ago

This feature refactors the observer usage, allowing to specify a name instead of handing over an instantiated class.

miguelgondu commented 3 months ago

Hey Simon!

It looks good, I'll download and test locally soon. Could I also ask you to update the tests (specifically those in test_observers.py)? That way I can get a feel of how you'd like observers to be used in practice.

miguelgondu commented 3 months ago

Also: #179

miguelgondu commented 3 months ago

Tests pass! :)

miguelgondu commented 2 months ago

Hey Simon!

One small question: I've been wondering whether we should add support to have several observers watch the same objective function. I'm starting to need that functionality in my project.

I can hack it by implementing a single observer that handles two different logging logics, so no worries and no rush.

SimonBartels commented 2 months ago

Hej Miguel, how about having a meta observer that just starts all the given observers? The question is how to specify which observers to start...