search

MachineMuse / MachineMusePowersuits

Minecraft mod, take 2
234 stars 103 forks source link

Helmet and Chestplate recipes failing to load #1002

Open 2CATteam opened 7 months ago

2CATteam commented 7 months ago

Version info Java version: Java 17.0.7 (I think - my Java installs are weird, but this should be irrelevant) Minecraft Forge version: 36.2.35 Minecraft version: Java 1.16.5 Powersuits version: 2.2.32

Describe the bug The Chestplate and Helmet are currently uncraftable. There is no recipe defined.

To Reproduce Steps to reproduce the behavior:

  1. Install the mods listed below
  2. Open a world, and note that JEI is unable to find any recipes for the Chestplate or Helmet

Expected behavior I'd expect the Chestplate and Helmet to have a recipe defined

Mod list Including versions, provided by crash report if game crashed: Can't find a way to make a good list with versions for all 76 of my mods (custom modpack), but I did exclusion testing, and was able to replicate the issue with only these mods:

  1. Curios, 4.1.0.0 (Lib for Occultism)
  2. GeckoLib 3.0.106 (Lib for Occultism)
  3. Modular Powersuits 2.2.32
  4. Numina 2.2.32
  5. Occultism 1.29.1 (Defines copper)
  6. Patchouli 53.3 (Lib for Occultism)

Additional context I've already been able to identify the issue; in the .jar file, there are recipes defined in data/powersuits/recipes/powerarmor_head and data/powersuits/recipes/powerarmor_torso, but the conditions here are wrong. In both cases, the condition being checked for is whether forge:ingots/copper is defined, but then the recipe USES forge:ingots/steel. As a result, because I have copper defined in my pack but not steel, there is no valid recipe. The other two armor pieces have the correct condition. I have already confirmed that fixing this by simply changing the condition to use forge:ingots/steel will close this issue, but I don't know where in the repo to make this change