search

MachineMuse / MachineMusePowersuits

Minecraft mod, take 2
236 stars 105 forks source link

Wearing power armour makes you invincible in lava/gives you a lot of defence #661

Open ghost opened 8 years ago

ghost commented 8 years ago

I'm not entirely sure what's up, but putting on 4 fresh/plain armour places and sitting in lava inflicts no damage. I take less damage from mobs and things too. This is with no upgrades and there are no armour icons next to the health bar. When I step out of lava the fire also stops ticking instantly.

MPS 283, Numina 131 - Tested on SSP Forge, the problem is worse in Cauldron for some reason, but that's probably not your problem

Xen1290 commented 8 years ago

Please, Update to MPS 290, reset your machinemuse config folder and try again.

ghost commented 8 years ago

290 doesn't make a difference, neither does resetting configs.

MachineMuse commented 8 years ago

If you are in a cold biome (drawn from Minecraft's own biome generation settings), the cooldown rate is very quick, even if you are underground. This is as designed, but maybe it's a problem?

eyeonus commented 8 years ago

I'm fairly certain he said there's no armour modules installed, so the suit shouldn't be taking the damage from the lava in the first place....

ghost commented 8 years ago

It's in a normal biome with no modules installed, here's a video: http://i.nentify.me/HQhl5la6.mp4

ghost commented 8 years ago

So is plain power armour supposed to make you invincible?

lehjr commented 8 years ago

I'm pretty sure it's a bug. I did encounter it a week or so ago, but haven't had a chance to look into it. Swimming in lava won't kill you, but the moment you get out, you'll be on fire and start taking damage from that. I'm fairly certain that isn't intended behavior, but there are different types of armor that do shield players from damage from lava... Quantum Suits from IC2 comes to mind.

MachineMuse commented 8 years ago

It is supposed to be a heat sink. You should be seeing a heat meter. I wonder why not..!

Unless you're in a cold biome, your heat will increase faster than it falls. In your demo video you're only spending 2-3 seconds in the lava at a time, which is not enough to increase it to harmful levels.

lehjr commented 8 years ago

I just tested it in my dev environment. The heat meter only rises steadily if you go to a depth of 2 blocks, otherwise it only pulsates. The video above looks like it was zoomed in, so you won't see the meters because they are on the side.

ghost commented 8 years ago

Hmm, if I swim around deeper, I eventually die from "death.attack.Overheat". I never see any bars though, and I don't think I lose any HP in 1-deep lava. Besides, the powersuit has no heat sink, armour, power, modules or anything. Shouldn't it be weak if it has no modules/power/etc?

lehjr commented 8 years ago

I think the meters don't show up unless the unit has a capacitor installed. It probably should be set to always show the heat meter though.

Edit: Yeah, looking at the code, the heat meter only shows up if maxEnergy > 0, which means you need a capacitor of any type installed. That should probably be changed.

eyeonus commented 8 years ago

That 1 deep lava thing just reminded me about another issue.

MachineMuse commented 8 years ago

ok, marking this as solved cause of PR #668

ghost commented 8 years ago

http://nentify.me/2015-12-18_10-05-02.mp4

So is it meant to act like this? This is with no upgrades (no heat sink or power, etc).

eyeonus commented 8 years ago

Looks to me like it might have a similar cause as the water tank issue I mentioned.

MachineMuse commented 8 years ago

We can look at adjusting the coefficients. They might have become outdated by some changes idk.

MachineMuse commented 8 years ago

Tagging it as a resource issue since it's technically a question of balance/numbers rather than code, although there isn't a way to modify this in configs at the moment.