search

MachineMuse / MachineMusePowersuits

Minecraft mod, take 2
236 stars 105 forks source link

Crash shortly after loading world #809

Open TeetoKaziim opened 7 years ago

TeetoKaziim commented 7 years ago

Powersuits version: ModularPowersuits-1.10.2-1.2.121.jar Forge version: Forge 12.18.3.2297

This crash also happened with: Forge 12.18.3.2297 ModularPowersuits-1.10.2-BETA-4

And goes away if I downgrade to ModularPowersuits-1.10.2-1.2.119.jar

My modlist is enormous, so it's probably some mysterious incompatibility, I wish I was more savvy and could give better information.

crash-2017-06-09_13.15.11-client.txt

This is the crash log it generates, I'm gonna see if I can narrow it down.

eyeonus commented 7 years ago

That's an odd error. It's saying ioob happened at a place that should never go oob.

"key == hotbarKeys[player.inventory.currentItem].getKeyCode()"

Why in heck did that have an index of 16??? There's only 9 slots on the hotbar!

lehjr commented 7 years ago

I have no idea how to replicate that, but this should fix it, I think. if (player.inventory.currentItem < hotbarKeys.length && key == hotbarKeys[player.inventory.currentItem].getKeyCode())

TeetoKaziim commented 7 years ago

Oh man, maybe it was because I'm using "dual hotbar", and maybe they do some wierd inadvisable or at least strange for other devs to anticipate stuff to enable the multiple hotbar behaviour. Thank you so much, I'm glad you were able to figure it out. Updated to the newest version and things are running swimmingly : D

eyeonus commented 7 years ago

Just so you know, as it stands now, power fist mode selection will only work in the vanilla slots.

It may be possible to make it work for the slots added by that mod you mentioned, but I've no idea how easy it would be.

lehjr commented 7 years ago

I'm guessing that's this one: https://minecraft.curseforge.com/projects/dual-hotbar/files

TeetoKaziim commented 7 years ago

Yeah that's the mod I was talking about.

I'll keep that in mind for personal use. You got hotter irons to fire than max-compatibility with a pretty edge case mod, so I'm not gonna be pushy about it.

I was actually getting the crash without having a powerfist crafted at all. I can't remember if the first time it started crashing (when I got BETA-4) if I even had any power armor items crafted, that was in my previous testing world and I think I was more focused on other stuff at the time so I just downgraded. Probably shoulda submitted an issue then, but kinda forgot...

In ANY case, seriously been loving the mod, it's great fun, I'll continue salivating in anticipation. Thankyou for the fix, and moreover thankyou for the whole mod. It scratches an itch that tech-heavy progression often sidelines, and scratches it in a fun way. Ya'all are sweeties.