search

MachineMuse / MachineMusePowersuits

Minecraft mod, take 2
236 stars 105 forks source link

Not deleting NBT's = Powersuit in Space #823

Open gdarai opened 6 years ago

gdarai commented 6 years ago

I would like to ask you to change the suit to not delete all NBT's on the suit when you put it on.

The reason: Advanced Rocketry now has aded an enchantment, which can make any armor airtight and thus usable as a space suit. Now, I can make MineTweaker Receipt to add this enchant to your armor pieces: recipes.addShapeless(<powersuits:powerArmorHead>.withTag({ench: [{id: 128 as short, lvl: 1 as short}]}), [<powersuits:powerArmorHead>, <minecraft:diamond>]); (It has some issues creating an empty dictionary like your default mmmpsmod: {}, but I can walk around this no problem) But it is worthless since your armor checks the NBT's when I put it on and when it does find anything else but the mmmpsmod tag it removes them.

Solution: Can you please turn this off in some son-ish fix, so I can start using this awesome suit in space? Also the same, when you put the pieces on the Suit Workbench.

lehjr commented 6 years ago

see response here: https://github.com/MachineMuse/MachineMusePowersuits/issues/798#issuecomment-342011351

Regardless of the cause, no fix is likely to happen soon. Currently every moment of my free time is tied up with a 1.12 rewrite, so I have to budget my time accordingly. When that's done I can put some time into backporting stuff to 1.10, but again, 1 person, 1 task.

gdarai commented 6 years ago

Thank you... this is great news. No pressure, I know how it is when you do something in your free time, so just enjoy. We will wait. For me this means that in near-is future, I may have a Space Dweling powerarmor or my modpack ... sweet.

lehjr commented 6 years ago

Note to self, enchantment tag is removed here: https://github.com/MachineMuse/MachineMusePowersuits/blob/1.10.2-Java/src/main/java/net/machinemuse/powersuits/event/PlayerUpdateHandler.java#L35-L39

lehjr commented 6 years ago

for 1.10.2, I'm going to fix this by not deleting that specific tag rather than just blindly deleting all or leaving them. In 1.12, I'll probably do something a little less hackish. Updated version should be up tomorrow

lehjr commented 6 years ago

this is addressed in commit https://github.com/MachineMuse/MachineMusePowersuits/commit/2e4706d2ad1c97df9d869579e56aa65c2f1e6ea1