Closed MJRLegends closed 6 years ago
Interesting. I'll look into this when I get a chance, but it will probably be a few days. I'm not sure if I'll be able to reproduce it or not, but I'll give it a shot. I do have some code from the 1.12.2 version that I'm working on that I can backport when it's done. It might help, might not. I just have to make sure I can do it without breaking any existing games.
Yeah i was able to reproduce it when i tested it so hopefully it will be reproduceable for you too
The problem is my computer has a hard time just running the mod pack and with default setting's I only see single digit frame rates.
Oh rip haha
Anything you can tell me about how you reproduced it? I tried to replicate the issue with 1.4.0 and couldn't.
MJR, the developer of the other mod, can't reproduce it either, and commented on that bug that he(?) thinks it's a Mac-only issue.
@aionys that turned out to be incorrect
@lehjr will see what i can do
Yeah, I saw that. :(
This should be fixed in the latest build
@lehjr Nice thank you, just out of interest what was underline cause?
I believe there were a few edge cases where the model was being called before it was fully loaded. The latest version contains a back port of the setup that will be used in the 1.12 version and should be far less error prone.
Nice i appreciate your work :D
Should be a bit more efficient but I haven’t had a chance to check the numbers.
I will reopen this if i see anymore issues related to this, thanks for your time
See https://github.com/MJRLegends/Space-Astronomy-2-Feedback-/issues/215 it contains already needed details