search

MachineMuse / MachineMusePowersuits

Minecraft mod, take 2
236 stars 105 forks source link

Changing Visuals causes disconnect from server #880

Open Lordmau5 opened 5 years ago

Lordmau5 commented 5 years ago

Minecraft Version: 1.12.2 Forge Version: 14.23.5.2796 MachineMusePowersuits Version: ALPHA-20

When trying to change the colors in the right side of the Visuals tab in the Power Armor Tinker Table whilst playing on a dedicated server, the server throws an error and disconnects the client. image https://paste.gg/p/anonymous/22d9a1084ba34f1f83dc12391bc6b7b4

From what I can tell the MPSNBTUtils.getMuseRenderTag has a reference to the DefaultModelSpec, which seems to be a client-only class, thus it can't find it.

lehjr commented 5 years ago

As soon as I get the cosmetic preset code fished, this will be fixed.

lehjr commented 5 years ago

This should be fixed in Alpha 21.

Lordmau5 commented 5 years ago

I assume that it is fixed, but the server doesn't even want to start with the newest Alpha build.

This is the newest crash - something in regards to the ServerProxy not being found:

https://paste.gg/p/anonymous/2deada5ac7f94ebda6c32b4e2019fe26

lehjr commented 5 years ago

o.0 I'll give this a look in a few minutes. Should have a fix up in a couple hours. Not a hard fix, just have some stuff to do at the moment.

Lordmau5 commented 5 years ago

Seems like a weird issue, considering that a ServerProxy file doesn't seem to be available anywhere in the .numina package... But glad to hear that it's not a hard fix :)

lehjr commented 5 years ago

It's because I eliminated the "common proxy" in favor of using the mod file to handle proxy tasks

lehjr commented 5 years ago

New alpha uploaded.

Lordmau5 commented 5 years ago

Server booted up again. Tried adjusting the colors through the cosmetics tab again and that worked now

The dedicated server still spews out some errors about trying to access a client class on the server https://paste.gg/p/anonymous/7b20a63fb91a4654aa5abfbe9399f939

Why is DefaultmodelSpec even being accessed on the server in the first place is what I'm curious about? Together with ModelRegistry and TexturePartSpec

lehjr commented 5 years ago

I probably just need to re-calibrate the precision hammer.

lehjr commented 5 years ago

Testing a "new" fix. Server load time is terrible (which is why there are so many server related issues) on my machine so it might be awhile.

lehjr commented 5 years ago

Fixed that, just need to fix an issue with the cosmetic selection with the power fist.

lehjr commented 5 years ago

There, should be usable now.

Lordmau5 commented 5 years ago

I'll report back in a bit, can't really test it right now. Thank you for the fix though :)

Lordmau5 commented 5 years ago

Alright, it doesn't throw errors anymore on the server :)

The only thing that doesn't work now is that the "Alpha" slider isn't doing anything, though I feel that's not really relevant to this issue in terms of it crashing (and probably also known)

lehjr commented 5 years ago

The alpha slider should work but the effect isn't really apparent in the cosmetic GUI. It's a limitation of Minecraft's rendering.