search

MachineMuse / MachineMusePowersuits

Minecraft mod, take 2
236 stars 106 forks source link

Enhancement - Liquid nitrogen integration #890

Open EngineerXL opened 5 years ago

EngineerXL commented 5 years ago

Other mods have nitrogen too, I'd be nice not to have two nitrogens image image

lehjr commented 5 years ago

Are other mods' liquid nitrogen compatible with each other?

EngineerXL commented 5 years ago

I have only TechReborn, that adds Nitrogen

lehjr commented 5 years ago

As I recall, there was a reason it was left as is, and that is due to the lack of an "oredict" for fluids. There's a fluid registry, but there's no easy way of telling whether or not a fluid already exists because "liquid_nitrogen" is not the same as "liquidNitrogen". Even in the case where there are oredicts, you still run into multiple versions of copper, tin, etc.

lehjr commented 5 years ago

For instance, Galacticraft uses "liquidnitrogen", but they could even use something like "liquidN" or "ln" or whatever. Because of this, there is no easy way to detect if another mod is adding that fluid. And while it's possible to deal with it on a mod by mod basis, this becomes a can of worms with a whole series of edge cases.