search

MachineMuse / MachineMusePowersuits

Minecraft mod, take 2
237 stars 105 forks source link

[1.12.2] Thaumcraft Cloudstepper ring conflict #916

Closed hiimcody1 closed 5 years ago

hiimcody1 commented 5 years ago

When using Thaumcraft and MPS together, the Cloudstepper ring no longer fires its double jump. Tested just TC (plus baubles dependency) and MPS (plus numia dependency) alone to confirm no other mods are mucking with things.

I imagine this is due to overriding player capabilities, something with the Cloudstepper may not play well with how jump-assist is handled, but admittedly I haven't looked at the MPS code in detail since 1.7.10, so I can only theorize right now.

I cannot locate a functional FAQ link to determine if this is due to new implemented behaviour/mechanics for the MPS mod.

Versions: Forge: forge-1.12.2-14.23.5.2814 Thaumcraft: Thaumcraft-1.12.2-6.1.BETA26 Baubles: Baubles-1.12-1.5.2 MPS: ModularPowersuits-1.12.2-1.0.37 Numina: Numina-1.12.2-1.0.36

Client Log

lehjr commented 5 years ago

Not something that can be easily fixed. The ring fails when **mc.gameSettings.keyBindJump.isPressed()** is used. Even commenting out all other code in the keybinding handler so that no values are set is still enough to cause the ring to not work.

hiimcody1 commented 5 years ago

Alright. Thanks for checking into it. I'll see if I can hack together a helper mod or something just for my own use in this case.

lehjr commented 5 years ago

I believe I have a fix for this. I've been testing it for the past few minutes.

hiimcody1 commented 5 years ago

I'm more than happy to test it out, would save me trying to get up to speed with 1.12.2's codebase.

lehjr commented 5 years ago

should be OK. I just moved the key handling for the jump and down keys to the player tick handler. Seems to be more or less OK now

hiimcody1 commented 5 years ago

Sounds good. I'll update my jar once changes are pushed. Thanks again for looking into this.