search

MachineMuse / MachineMusePowersuits

Minecraft mod, take 2
234 stars 103 forks source link

[Bug] Keybinds not registering after relog after long time #924

Open MagicalMongoose opened 5 years ago

MagicalMongoose commented 5 years ago

Sometimes after you relog on a server, the keybinds which are on your HUD will disappear and you can't use those binds unless you go into the tinker table to refresh the keybinds screen which will fix the bug until you relog after ??? time.

eyeonus commented 5 years ago

Please see #923

lehjr commented 5 years ago

I can probably fix this for 1.12.2 by moving the keybind loading to the login event. However, since Java 8 is now EOL, I won't be working on anything older.

Caaruzo commented 4 years ago

Version info Java version: 1.8.0_222 Minecraft Forge version: 1.12.2-14.23.5.2838-universal Powersuits Version: ModularPowersuits-1.12.2-1.0.46

Same Problem for me would love to see that fixed for 1.12.2. Might that be possible in future?

lehjr commented 4 years ago

with a team of ONE person and the 1.14.4 port under heavy development, 1.12.2 fixes aren't even on the radar at the moment.

Caaruzo commented 4 years ago

but whats in future? Thats why i asked.

lehjr commented 4 years ago

Here's the deal. The 1.12.2 and 1.14.4 codebases are very different and backporting isn't going to be an easy task. On top of that, MPS for 1.12.2 in a development environment has about a 2-3 minute load time. Doesn't sound like much, but if you want to make small changes and reload, it becomes a nightmare. On top of all that, picking up a code base that you haven't touched in months isn't as easy as you would think. Think of each port as almost an entirely different project rather than a continuation. And things that work in one Minecraft + Forge version aren't going to work in another. Once I release the mod for 1.14.4, I then have to focus on bug fixes and maintenance of that. MPS is a very difficult mod to maintain because so much of it is done in a non-standard way for the sake of customization. So what does the future hold, it's hard to say.

On top of all of this, I need to move everything. Why? Well, because I have not heard from MachineMuse since early 2016, yet she has control over everything. She has control over the CurseForge project pages for Numina and MPS. She has control over the repos as well and I cannot even change the default branch here. So I can either move everything, or I can let the mod die.

Caaruzo commented 4 years ago

Well ifc let the mod die isnt an option. But iam happy to hear, that it might be maybe possible to get bug fixes on 1.12.2. Cause most packs (ofc also our own private one) run on 1.12.2. Cause most mods exists for after the 1.7.10 hype xD. Thx for your work also and keep it up :) Oh y btw i think moving should be an option if it helps you :)

lehjr commented 4 years ago

I plan on doing a 1.12.2 maintenance release, or 2. However, when is another matter altogether.