search

MachineMuse / MachineMusePowersuits

Minecraft mod, take 2
237 stars 105 forks source link

Fall damage bug in modpack. #935

Open RemiBraizet opened 5 years ago

RemiBraizet commented 5 years ago

Version info Java 8 update 191 1.8.0_191-b12 Minecraft Forge version: 14.23.5.2768

Describe the bug no Power armor equiped at all. nothing. 4 block height -> fall -> 1 half heart damage 4 block height -> jump then fall -> still 1 half heart damage expected 1 full heart of damage

even more, the not taken fall damages accumulates, and sometimes at falls of 1/2 blocks high, you take the damages you did not take before.

To Reproduce Steps to reproduce the behavior: as i'm playing on a private modpack i think i'm not authorized to post the link here. 1 install the modlist (see below) 2 launch the game in survival

  1. simply fall from 4 block, constating the half heart damage
  2. re-do it but jumping before falling (so the fall is 5.5block height) constating you're still taking 1half heart instead of full one
  3. the 'non-delivered' fall damages is really random when it comes out, but just jump sprinting for a while will trigger them

Expected behavior taking normal fall damages without ghosty sneaky unapplied fall damages Mod list modlist: https://ibb.co/2Wn71b8

exclusion tests: i removed a half of my mods, it was working, from the half of mods removed, i reinstall half of this half, recursively, and finally found mps causing this. if its not in, no problem, in, all problems. i did not tested the mod alone yet.

Log files latest.log, it may https://gist.github.com/Remaetanju/58a523309f13f4fa07e4d4463ec6b1a3

additionnal info betterfps and optifine could making this bug worse. (as i already saw similar github issue on vanillafix) but removing it before any exclusions test, i could not tell you much more.

The bug is NOT happening to me in vanilla minecraft (from this thread) https://github.com/MachineMuse/MachineMusePowersuits/issues/899

thank you, and keep this great mod alive :)

lehjr commented 5 years ago

Unfortunately, the same answer applies as I simply do not have the time to track this down. Every bit of my spare time is going towards porting to 1.14.2 and can either work on one, or work on the other, but one person alone cannot do both.

The only place in the mod where fall distance is tracked and damage is applied is here: https://github.com/MachineMuse/MachineMusePowersuits/blob/1.12.2-experimental/src/main/java/net/machinemuse/powersuits/event/MovementManager.java#L224-L247

RemiBraizet commented 5 years ago

Have you any discord ? i would be glad if i could help investigating on this also, is there a chance to have a change on the handleFallEvent in downgraded version of mps for 1.12.2 ?

lehjr commented 5 years ago

I really don't use discord. I think I've used it once or twice. I really don't even have time to mess with it. As for the other question, I have no idea what you mean. It's not that it can't be changed, it's that every change requires testing. I have no time for that. The event isn't even processed by the mod unless the distance is over 3.0. The problem is I just don't have time to mess with it to even determine if the issue is there or somewhere else.

lehjr commented 5 years ago

There, setup. Don't expect much activity there though

https://discord.gg/8rUE6P

axj2466 commented 4 years ago

Do you have any plans to fix this for 1.12.2? It pretty much makes using jetpacks/boots impossible because any time you fly more than a couple blocks high, you accumulate all the fall damage when you land, no matter how fast you are going. Thus you die pretty much every time you try to land.

lehjr commented 4 years ago

Unfortunately, Forge no longer supports 1.12.2, and is now 2 versions behind the latest. On top of that, there's a bug with the latest JDK which causes Minecraft to not even run.

If I get time, I'll look into it, but it's no longer a priority. On the other hand, Forge 1.14.4 has LTS support, so there's that. But after 1.12.2, MPS will be replaced with MPA.