search

MachineMuse / MachineMusePowersuits

Minecraft mod, take 2
236 stars 105 forks source link

Active Camouflage module affects only the chestplate #955

Closed EzerArch closed 4 years ago

EzerArch commented 4 years ago

Version info Java version: 1.8.0_51 Minecraft Forge version: 1.12-2847 Modular PowerSuits: 1.12.2-1.0.46

Describe the bug The Active Camouflage module affects only the chestplate.

To Reproduce Steps to reproduce the behavior:

  1. Equip 5 armor pieces: helmet, chestplate, laggings, boots and power fist;
  2. At the Tinker Table, install a battery in all armor pieces and the Active Camouflage in the chestplate;
  3. Add a keybind to toggle the Active Camouflage (here I'm using "I") and use it;
  4. Only the chestplate and the player model become invisible. The other armor pieces don't.

Expected behavior All parts of the armor become invisible.

Screenshots 2020-02-21_18 32 49 2020-02-21_18 33 01

lehjr commented 4 years ago

unfortunately, the current java 8 version (openjdk8 -242) breaks forge gradle 2.x and anything using it is no longer supported by Forge. As such, this breaks development environments for any version older than 1.13.x Using an older version of Java is not trivial, and using a newer java branch is not possible.

EzerArch commented 4 years ago

As such, this breaks development environments for any version older than 1.13.x

So this may be fixed or fixable in 1.14+?

lehjr commented 4 years ago

Yes.

lehjr commented 4 years ago

fixed in 1.14.4.

EzerArch commented 4 years ago

Close it?

lehjr commented 4 years ago

won't make much difference either way since everything from 1.14.4 onward is in the MPA fork.