search

MachineMuse / MachineMusePowersuits

Minecraft mod, take 2
236 stars 105 forks source link

1.12.2 Power Fist Silk Touch module/upgrade doesn't work #963

Closed Travis9x closed 4 years ago

Travis9x commented 4 years ago

Version info Java version: 1.8.0_241 Minecraft Forge version: 14.23.5.2847

Describe the bug The Silk Touch upgrade for the Power Fist does nothing. Mining stone/ores still breaks the blocks, instead of collecting the intact block. The rest of the Pickaxe module still works fine, as far as I can tell.

To Reproduce Steps to reproduce the behavior:

  1. Build a Power Fist and Tinker Table.
  2. Build and install Pickaxe module for the Power Fist.
  3. Build and install the Silk Touch upgrade for the Pickaxe module. (I also had the Diamond Drill upgrade installed...not sure if this would affect it)
  4. Mine any stone, or ore that normally "breaks" (such as coal/redstone). Notice that the stone/ore still breaks as with a normal pickaxe.

Expected behavior It would be expected that the Silk Touch upgrade works the same as the Silk Touch enchantment, and enables the user to collect intact blocks.

Mod list No game crash. Just a non-functioning feature. I have not done any exclusion-testing with other mods, so I don't know if another mod may be causing this. With that said, I do have both of the mods Modular Powersuits is supposed to be compatible with, namely Ender IO and all of CoFH's Thermal series. Some other mods that may or may not affect this functionality, is Tinker's Construct (due to similar functions/features, and tie-in with both Ender IO & Thermal series), and Draconic Evolution (simply due to how huge this mod is).

Log files Game log (make sure it's the log that was generated during the gameplay the issue occurred in): https://gist.github.com/Travis9x/31e7195cd162f664d6577a5eb68f5991 Crash report (if issue caused game to crash): N/A Server log (if issue occurred on a server, make sure it's the log generated during the gameplay the issue occurred in): N/A Server crash report (if issue caused server to crash): N/A

Screenshots I'll add one later

Additional context I have not tested with any other "harvesting" modules (shovel, axe, etc.)

Travis9x commented 4 years ago

Nevermind, I didn't realize that Silk Touch was a "mode" that I had to specifically select. Although in hindsight, this actually makes sense, and is better than the Silk Touch effect just being always/permanently active all the time.