search

MachineMuse / MachineMusePowersuits

Minecraft mod, take 2
234 stars 103 forks source link

[1.16.4] Observations #985

Closed CrossVas closed 3 years ago

CrossVas commented 3 years ago

Version info Minecraft version: 1.16.4 Minecraft Forge version: 35.1.28

Describe the bug

  1. Workbench missing model and localization;
  2. Silk touch enchantment module missing texture;
  3. Armor is listed upside down in workbench when equipped;
  4. Workbench doesn't show you the required materials when you choose a module to install;
  5. Recipes are messed up (components can't be crafted), it needs to be polished;
  6. Components don't stack;
  7. Modules missing options' localization;
  8. Salvation button sometimes doesn't work (when you install a module and then try to uninstall it) - tried with amor plates
  9. Armor plates have no effect (you can install them, but get 0 armor points)

It is impossible to do some more testing unless these (or at least item stacking) are not fixed

Mod list ftb-gui-library-1604.1.1.26; jei-1.16.4-7.6.0.57; ModularPowersuits-1.16.4-2.0.1; Numina-1.16.4-2.0.1.

Log files latest.log pastebin

Screenshots

2021-02-03_22 03 22 image

image image image image

EzerArch commented 3 years ago

Wrong repository, please: https://github.com/lehjr/ModularPowerArmor (ping @lehjr )

lehjr commented 3 years ago

Wrong repository, please: https://github.com/lehjr/ModularPowerArmor (ping @lehjr )

actually, it's this one: https://github.com/lehjr/MachineMusePowersuits Since I have access to the Curseforge page again, it's just easier since everyone knows MPS better than MPA.

lehjr commented 3 years ago

  1. Workbench missing model and localization; Not actually missing, just missing proper reference. Already fixed in code.

  2. Silk touch enchantment module missing texture; The silk touch doesn't have an icon yet. I'm still not even sure what that should look like.

  3. Armor is listed upside down in workbench when equipped; That's a sorting issue related to how Minecraft handles it's slots. It's probably not going to get fixed right away. It's annoying but it's not game breaking and I'm looking at replacing parts of the GUI at some point.

  4. Workbench doesn't show you the required materials when you choose a module to install; Install costs were removed after 1.12 due to use of capabilities. Modules are now items and are directly crafted.

  5. Recipes are messed up (components can't be crafted), it needs to be polished; Like other things, recipes are still a work in progress. The biggest issue is that having recipes specifically tailored to other mods like in previous versions only works when those mods are installed. Since the mod doesn't add its own materials, vanilla recipes are pretty limited and "uninspiring".

  6. Components don't stack; Fixed in code, will be in the next alpha.

  7. Modules missing options' localization; Mostly fixed in code.

  8. Salvation button sometimes doesn't work (when you install a module and then try to uninstall it) - tried with amor plates Confirmed. Probably going to take quite a bit of time to fix this.

  9. Armor plates have no effect (you can install them, but get 0 armor points) Fixed in code, will be fixed in next alpha.

CrossVas commented 3 years ago

@lehjr, could you please open the Issue tab on your fork to post further results there since this repo is not active?

lehjr commented 3 years ago

@lehjr, could you please open the Issue tab on your fork to post further results there since this repo is not active? The repo accepts issues now. I'll probably have a few more to add.

CrossVas commented 3 years ago

@lehjr what do you think about these one for fortune and silk modules? modules.zip

image

image

lehjr commented 3 years ago

@lehjr what do you think about these one for fortune and silk modules? Looks good to me.

Crimsonhime327 commented 3 years ago

image image

there is missin texture or something on the power gauntlet. and i can't install some upgrades no matter how many times i try

Crimsonhime327 commented 3 years ago

how we're supossed to charge the batteries anyway?

Crimsonhime327 commented 3 years ago

image i can't install those upgrades

lehjr commented 3 years ago

how we're supossed to charge the batteries anyway?

Charge pad from numina or energy generator. There really isn't much in the mod as far as energy generation, solar generators, thermal, and kinetic.

lehjr commented 3 years ago

Unlike previous versions of the mod, there is a limit as to what can be installed. For instance, only one energy storage device can be stored in any single piece of armor. The GUI needs to be updated to reflect this, but that's a bit far down on the list of priorities

CrossVas commented 3 years ago

I guess this issue can be closed as now we have issue tab on your fork, @lehjr, right?

UPD: Further info/discussion could be done/written there.