search

MachinePublishers / jBrowserDriver

A programmable, embeddable web browser driver compatible with the Selenium WebDriver spec -- headless, WebKit-based, pure Java
Other
809 stars 143 forks source link

Remove usage of Selenium RC classes #216

Closed valfirst closed 7 years ago

valfirst commented 7 years ago

Remove usage of com.thoughtworks.selenium.SeleniumException.

Selenium RC is officially dead. com.thoughtworks.selenium.SeleniumException was excluded from Selenium 3 (starting from 3.0.0-beta3). This commit removes this dependency. IMHO, it's better to support new releases 3+ rather than dead RC.

Issues/question references: #213 , #207 , #196

hollingsworthd commented 7 years ago

Yes, agreed. I would always prefer Selenium 3.x support over 1.x, especially in a case such as this which is basically just an edge case and non-critical for 1.x code (but critically breaks 3.x builds). Thanks!

hollingsworthd commented 7 years ago

This is now released to Maven Central, v0.17.1.