search

MachinePublishers / jBrowserDriver

A programmable, embeddable web browser driver compatible with the Selenium WebDriver spec -- headless, WebKit-based, pure Java
Other
809 stars 143 forks source link

Block Media Feature by @vosmith, cleaned by @medavox #328

Closed medavox closed 5 years ago

medavox commented 6 years ago

Adds flag to optionally block downloading media elements. Implements #119. I am not the author of this work (@vosmith is), but I would like to see it included in the main repo.

By the looks of it, their fork was a custom feature-fork for a company @solebrity, so I don't know if there was any intention to make a PR -- which is a shame because this feature has been requested before (see #119)

I've included the commits implementing this feature, but excluded some extraneous commits from @solebrity 's fork (such as build modifications and a copy of the ad hosts file).

hollingsworthd commented 5 years ago

Looks good. Thanks for submitting this!