Maciej916 / Ma-Enchants

Adds various new enchant and curses to the game
GNU Lesser General Public License v3.0
3 stars 8 forks source link

Inconsistency in Mod ID across versions causes compatibility issues #44

Closed Dariensg closed 1 year ago

Dariensg commented 2 years ago

Ma Enchants for 1.16 has the Mod ID "ma-enchants," while 1.17 and 1.18 have the Mod ID "maenchants." This can cause issues with compatibility with other mods that rely on the Mod ID to determine compat features. One such example is the mod Neko's Enchanted Books, which relies on Mod IDs to assign custom book textures to enchantment books. Mod IDs should typically never be changed if at all possible for reasons such as this, and in cases where they must be changed, the change should be reflected across all versions. It would be great if you could please update the Mod ID of one type or the other so that there is consistency, thank you!

Maciej916 commented 1 year ago

Modid will not longer change since 1.18