search

Macil / browserify-hmr

Hot Module Replacement plugin for Browserify
MIT License
373 stars 26 forks source link

Do not fail on wrong source map. Fixes #9 #10

Open royriojas opened 8 years ago

Macil commented 8 years ago

Sorry for the lack of a more timely response to this!

I'm more than a little hesitant to merge in a change that makes browserify-hmr silently ignore and replace sourcemaps in some situations. Logging the fact the issue happened would be a bit better, though I'd rather identify the other transforms that create bad or incompatible sourcemaps and try to fix their problem.

royriojas commented 8 years ago

No problem man, Sadly not all transforms play nice with source maps so for those cases I would still suggest to consider some kind of workaround. Maybe an option or something. Logging it is definitively better than failing silently. For now this workaround is good enough for my use case.