search

Macil / browserify-hmr

Hot Module Replacement plugin for Browserify
MIT License
374 stars 26 forks source link

Live Reloading #15

Open mattdesl opened 8 years ago

mattdesl commented 8 years ago

First, great work on this module. It works well with budo.

In webpack, when a module without module.hot (like the app root) is changed, it triggers a full page refresh. I am not sure how to achieve this with browserify-hmr. I can include LiveReload but then any module changes will trigger a full page refresh.

Any ideas?

Macil commented 8 years ago

This isn't currently supported. It could be added as an option, though it's blocked on #14 as browserify-hmr currently fails to correctly identify the situation where a module without module.hot is changed. (I previously started adding some tests to identify the situation in the "fail" branch. That bug is causing an increasing number of people problems lately; I should focus on it soon.)

ashaffer commented 8 years ago

Huge +1 from me on this. Anything I can do to help out here?

ashaffer commented 8 years ago

@AgentME I sent over a PR that addresses this at least in a temporary way in #20, and @mattdesl it works nicely with budo for me.