search

Macil / browserify-hmr

Hot Module Replacement plugin for Browserify
MIT License
373 stars 26 forks source link

Problem with engine-io #23

Closed Industrial closed 8 years ago

Industrial commented 8 years ago

Hi.

I'm having this problem with engine.io-client:

http://i.imgur.com/Kbw6a1l.png

it's on line 214 in the screenshot, seems to return undefined.

Macil commented 8 years ago

I can't reproduce this issue. I'm curious about what version of socket.io-client you're using. Can you post the output of npm ls from within your project?

Industrial commented 8 years ago

This is the project: https://github.com/Industrial/test-loopback

so this might reproduce the problem (install might take a while):

git clone https://github.com/Industrial/test-loopback.git;
cd test-loopback;
npm install;
gulp develop;
Macil commented 8 years ago

Did you solve the issue? I've been able to reproduce it in your project now.

Industrial commented 8 years ago

I didn't solve it yet but it's definitely not a problem with browserify-hmr. It's the way I am trying to split up the bundles into a node_modules.bundle.js and app.bundle.js. There's some stuff going wrong with the bundling so the node_modules doesn't include all code and some modules are pointing to themselves (infinite loop).

Macil commented 8 years ago

Bundle splitting isn't something I've tested with browserify-hmr. If your project works when you disable browserify-hmr, then it's probably browserify-hmr's fault.