Open Mackenzie-Frey opened 5 years ago
Partial for Follower/Following in user/show.html.erb
Facade making a follower and following contain same logic.
Ensure all applicable tests are utilizing WebMock, rather than expecting values from the API response. (roughly 1-2 tests early-on).
User_sees_github_spec.rb Pull out logic to do setups for the test to make DRY.
user_can_add_see_friends>spec.rb - extract logic into before each block for test set_up
check all tests for refactors
Check for unused routes.
Change class method for User.is_user? to an instance method by scoping to trusted object current_user.
Make bookmark button disappear for a video once it has already been bookmarked.
Email Activation Process: Brainstorm on how to make the messages mire obvious ie red and flash messages
Combo these AR queries into one query: not_a_friend? and get_user_id for Follower.
Observe if when a user hits their email activation if the error message sticks around that they need to still activate.
Partial for Follower/Following in user/show.html.erb
Facade making a follower and following contain same logic.
Ensure all applicable tests are utilizing WebMock, rather than expecting values from the API response. (roughly 1-2 tests early-on).
User_sees_github_spec.rb Pull out logic to do setups for the test to make DRY.
user_can_add_see_friends>spec.rb - extract logic into before each block for test set_up
check all tests for refactors
Check for unused routes.
Change class method for User.is_user? to an instance method by scoping to trusted object current_user.
Make bookmark button disappear for a video once it has already been bookmarked.
Email Activation Process: Brainstorm on how to make the messages mire obvious ie red and flash messages
Combo these AR queries into one query: not_a_friend? and get_user_id for Follower.
Observe if when a user hits their email activation if the error message sticks around that they need to still activate.