Maclay74 / steam-patch

Some Steam patches, fixing broken Steam features on Asus Rog Ally
MIT License
31 stars 16 forks source link

[Rog Ally][ChimeraOS] Changing TDP does not change thermal policy #4

Closed ashtophet closed 1 year ago

ashtophet commented 1 year ago

Steps to reproduce:

Check /sys/devices/platform/asus-nb-wmi/throttle_thermal_policy (defaults to 0).

Change TDP to 30W.

Check /sys/devices/platform/asus-nb-wmi/throttle_thermal_policy : it's still 0

This issue was present too before 0.6 version.

P.S.: I don't know if it has been changed with the new BIOS (I'm using latest, 323), but this seems to not be correct in my machine: // Update thermal policy let thermal_policy = match tdp { val if val < 12 => 0, // silent val if (12..=25).contains(&val) => 1, // performance _ => 2, // turbo }; From my testing, 0 would be balanced, 1 would be performance and 2 would be silent. Test with a game (A plague tale innocence, high-ultra settings):

Maclay74 commented 1 year ago

Hey, thanks for the report. I will check it out and get back to you with an update.

Maclay74 commented 1 year ago

The only one thing I don't understand is the relation between TDP and thermal policy. Does changing thermal policy changes TDP on your device?

ashtophet commented 1 year ago

Yes. With BIOS 323 a change in thermal_throttle_policy has an inmediate effect on TDP here

ashtophet commented 1 year ago

Here is a video that shows the behaviour. It starts a game (A plague tale innocence) with default settings. Thermal throttle policy = 0. Then using TDP control, it ups TDP to 30W. Thermal throttle does not change. If we change thermal throttle it changes inmediatly TDP (tested with 1,2 and 0)

https://streamable.com/t7ao1s (exires in 2 days)

Maclay74 commented 1 year ago

I pushed a new release, can you please try 0.6.1?

ashtophet commented 1 year ago

Fixed! Thank you very much!