Macmod / godap

A complete TUI for LDAP.
MIT License
209 stars 7 forks source link

feat: get password/hash from a file #1

Closed jolheiser closed 7 months ago

jolheiser commented 7 months ago

This allows the user to pass a filepath to get the LDAP password/NTLM hash from rather than exposing them to shell history/process table

Macmod commented 7 months ago

Hey @jolheiser,

I agree it's a good idea. Can you also extend it to set the ntlmHash instead of the LDAP password if -H was provided by the user?

Also --passfile seems like a better argument name, if you could change it please.

Thanks for the PR 😄

jolheiser commented 7 months ago

I've added another flag separately for the NTLM hash (--hashfile), it seemed like a better UX since -H is a string flag (but feel free to tell me otherwise!)

Macmod commented 7 months ago

Merging this. Good work mate! 👍