search

Macquarie-MEG-Research / natural_conversations

Data analysis for the natural conversations study
0 stars 2 forks source link

ENH: add speech timestamps to _events.tsv file #7

Closed larsoner closed 9 months ago

larsoner commented 9 months ago

Turning this into a PR so we can see the diff easily @JD-Zhu !

larsoner commented 9 months ago

@JD-Zhu short version here is that if you do raw.set_annotations(...) on a file before calling write_raw_bids, it automatically converts annotations to events and puts them in _events.tsv. Can you check this file that I generated on 5e12441 against one you generated to make sure they match? Had to rename the extension to make GitHub happy with the upload:

sub-01_task-conversation_run-01_events.txt

JD-Zhu commented 9 months ago

@JD-Zhu short version here is that if you do raw.set_annotations(...) on a file before calling write_raw_bids, it automatically converts annotations to events and puts them in _events.tsv. Can you check this file that I generated on 5e12441 against one you generated to make sure they match? Had to rename the extension to make GitHub happy with the upload:

sub-01_task-conversation_run-01_events.txt

Yep I have checked this events file and it matches the one I generated.

JD-Zhu commented 9 months ago

@larsoner Should we merge this PR?

larsoner commented 9 months ago

Yes if you're happy feel free and we can keep iterating in future PRs