MadDeCoDeR / Classic-RBDOOM-3-BFG

DOOM: BFA (Big Freaking Anniversary) Edition (former Classic RBDoom 3 BFG) is a source port based on RBDOOM-3-BFG and enchance the experience of Ultimate DOOM, DOOM 2 and DOOM 3.
GNU General Public License v3.0
215 stars 22 forks source link

[Classic DOOM]Master Levels WAD generation #80

Closed MadDeCoDeR closed 1 year ago

MadDeCoDeR commented 2 years ago

Describe the bug The Master Levels WAD is getting generated regardless if the WAD files exists and the expansion menu pass it resulting into CTD.

To Reproduce Steps to reproduce the behavior:

  1. Make sure you don't have MASTERLEVELS.WAD in either the game's /wads folder or in the save's directory /wads folder
  2. Similar to Step 1 but for the master folder or master.zip which contains the original master levels
  3. Open DOOM BFA
  4. Open DOOM 2
  5. Start a New Game
  6. Select the Master Levels expansion
  7. You will get the option to select the difficulty instead of a message telling you that the expansion is missing

Expected behavior After selecting the Master Levels expansion it should have show you the basic error message that the expansion file is missing

Desktop (please complete the following information):

Additional context The WAD generation should occur ONLY when the game detects either the master folder or the master.zip. And even if the file is trying to get generated upon error it should be deleted.

ViperAcidZX commented 1 year ago

I have all of the master levels WAD files in the master folder within the \base\wads folder and it is not generating anything now.

MadDeCoDeR commented 1 year ago

Thanks for the feedback. This also help me to resolve and another issue. At worst in an hour from now the nightly build will be ready