search

MadJavaEntSpring2017 / assist

0 stars 0 forks source link

Project Code Review #2

Open hhollister opened 7 years ago

hhollister commented 7 years ago

Design/Code Review 1

Project: Team Tracker

Developer: Ben

Reviewer: Heather

Category Criteria Rating/Comments
Problem Statement Does it exist? reviewer rating/comments go here
Does the problem statement accurately describe project purpose? Yes
Is the problem statement professional? Think of prospective employers viewing this as part of the developer's portfolio. Yes, I think it was written well.
What is good? It clearly identifies how he got the idea and what he would like to fix.
What could be improved? I can't think of anything.
Design Documentation Does it exist? Yes
Is the navigation/flow through the application logical and easy to use? Yes, it makes sense.
Is the order in which the fields are displayed and form fields entered logical and easy to use? I believe so
What data is missing? Just figuring out the difference between a manager view versus a players view
Is there data that is not used? Not that I know of
What is good? Has a clear vision of what he would like it to do which gives him a good start on what it needs to look like.
What could be improved? Nothing I could think of when we met.
Data model Does it exist? I didn't see it up here, but he showed us when he talked about it.
Is everything on the screens represented in the model? Yes, he was very detailed.
Does the model represent good database design? Yes, very much so, he seemed to have thought out everything already
What is good? As far as I could tell, he did a very good job thinking everything out and coming up with a logical plan.
What could be better? Nothing that I could see
Additional design documents
Application structure in IntelliJ Does it exist? It appears to
Is the structure correct for a Maven project? Appears to be
Are packages and classs appropriately named? Appears to be
Other comments/notes? Off to a great start!
JSPs Do they exist? A few of them
Is templating used (for example, header.jsp, footer.jsp, etc.)? Yes
Is there business logic mixed in the JSPs? ?? Not sure what this means
CSS? Didn't see any posted yet
Other comments/notes? N/A
hhollister commented 7 years ago

Sorry for the delay!