MadJoker0815 / roborock_nologs

No reboots at 3am and no logfiles that fill up the disk and checks to keep filesystem healthy
25 stars 1 forks source link

Install-script - `/dev/shm/*.old'` #2

Closed exetico closed 4 years ago

exetico commented 4 years ago

Hi,

Thanks for the fixes - and the script, too.

Maybe it could be a good idea, to remake the "Readme" - i can help, if you like.

Also, i have a question, related to the script.

My Xiaomi Roborock S5/S50 did reset the other day, and today, i installed my custom firmware (again), and started this script.

I saw an issue message, related to rm the old-files.. It's reporting that no files could be found, matching /dev/shm/*.old'

Output:

./install.sh 
Before installing, please check if the cron jobs have not been set yet. Otherwise it will add a different line in /etc/crontab.
Press Enter to continue
^C
root@rockrobo:~# nano /etc/crontab
root@rockrobo:~# cat /etc/crontab
# /etc/crontab: system-wide crontab
# Unlike any other crontab you don't have to run the `crontab'
# command to install the new version when you edit this file
# and files in /etc/cron.d. These files also have username fields,
# that none of the other crontabs do.

SHELL=/bin/sh
PATH=/usr/local/sbin:/usr/local/bin:/sbin:/bin:/usr/sbin:/usr/bin

# m h dom mon dow user  command
17 *    * * *   root    cd / && run-parts --report /etc/cron.hourly
25 6    * * *   root    test -x /usr/sbin/anacron || ( cd / && run-parts --report /etc/cron.daily )
47 6    * * 7   root    test -x /usr/sbin/anacron || ( cd / && run-parts --report /etc/cron.weekly )
52 6    1 * *   root    test -x /usr/sbin/anacron || ( cd / && run-parts --report /etc/cron.monthly )
#
root@rockrobo:~# ./install.sh 
Before installing, please check if the cron jobs have not been set yet. Otherwise it will add a different line in /etc/crontab.
Press Enter to continue

Install cron tasks.
cron stop/waiting
cron start/running, process 27389
Modify logrotate.sh to be not as aggressive and delete old log files.
logrotate stop/waiting
logrotate start/running, process 27405
Executing check_reboot script takes aprox. 1 min.
rrwatchdoge stop/waiting
rm: cannot remove '/dev/shm/*.old': No such file or directory
rrwatchdoge start/running, process 27742
ALL DONE!
Please check your robot for function

Maybe, you should just implement -f in the command:

-f, --force
          ignore nonexistent files, never prompt
MadJoker0815 commented 4 years ago

Thanks for the information. Is changed in the install.sh