MadKudu / node-hubspot

Node wrapper for the HubSpot API
MIT License
192 stars 157 forks source link

Implement owners.betById #183

Closed antoine-pous closed 5 years ago

antoine-pous commented 5 years ago

Why:

Note: RemoteType and OwnerType are not really explained in the API doculmentation, then i don't really know which presets exists. If you've them i can easily improve types.

I've moved from nock to HS demo API for one reason, for a project like this one, which wrap an API which is maintained by other devs you can't trust at 100% your work. To avoid mistypings due to undocumented changes the best way is dealing with the API. The test duration is not a big issue and adding a daily test job let you know when the package is no anymore compliant with the current API version.

Maybe am i wrong, but i don't think.

Related issues: #181 and #182

antoine-pous commented 5 years ago

Some other tests than mine failed :/

antoine-pous commented 5 years ago

@pcothenet can you review this PR please?

FalconPilot commented 5 years ago

+1