search

MadLittleMods / markdown-icons

Easily display icon fonts in markdown.
Other
13 stars 12 forks source link

extension with config data raises an error. #8

Open sander76 opened 5 years ago

sander76 commented 5 years ago

@MadLittleMods Just checking: Has this ever worked?

md = markdown.Markdown(extensions=['iconfonts(prefix=mypref-)'])

Adding the prefix=mypref- raises an error with the latest version of markdown.

MadLittleMods commented 5 years ago

@sander76 There are tests for it, https://github.com/MadLittleMods/markdown-icons/blob/d707cc413754854221920249d1820e54dfc845ad/tests/test_iconfonts.py

sander76 commented 5 years ago

@MadLittleMods I know. I ran them. They failed when you include the extra config data inside quotes. If you look at the markdown docs it doesn't show the option. That's why I was wondering: could it be it is not supported anymore? Thinking further, should the current code be considered legacy and start a new plugin (or new version) supporting only the current version of markdown and python version>3.4 ?

MadLittleMods commented 5 years ago

@sander76 Yes, it was only tested in older versions of Markdown and is why I asked you if it worked here, https://github.com/MadLittleMods/markdown-icons/issues/6#issuecomment-438792448

sander76 commented 5 years ago

@MadLittleMods I guess I was a bit quick on the conclusion. I have been using your plugin for a couple of years, but only with the "basic" configuration which works just fine. After I found out it worked for me I thought all was fine not really looking at the other options the plugin provides.... 🙄.

So not sure how to proceed now...

sander76 commented 5 years ago

@MadLittleMods Sorry about this

sander76 commented 5 years ago

@MadLittleMods I am totally fine to create a trimmed down version of your plugin and giving you all credits. I don't think I can live up to the expectation of both keeping backwards compatibility, upgrading to the new markdown version and keeping all config options intact....

MadLittleMods commented 5 years ago

@sander76 We can create a new v3 branch for use with the latest Python markdown version

Since it is a major version, it can have breaking changes