search

MadLittleMods / node-usb-detection

List USB devices in system and detect changes on them.
MIT License
370 stars 114 forks source link

build(prebuild): update prebuild dependencies to latest #106

Closed mcous closed 4 years ago

mcous commented 4 years ago

node-abi, which is a dependency of prebuild and prebuild-install, contains the logic for which Node versions prebuild --all compiles for and subsequently publishes to GitHub releases.

package-lock.json had locked the version of node-abi to a version (2.2.0) from about 2 years ago, leading to a drastically outdated list of precompiled Node versions. This PR uninstalls and then reinstalls prebuild and prebuild-install to pick up the latest version of each as well as the latest version of node-abi.

I haven't been able to get my computer's node-gyp set up properly, so I haven't been able to test this yet. But, if everything works out, I think this should fix #85 and fix #104

MadLittleMods commented 4 years ago

Thanks for looking into this @mcous! Your explanation makes sense to me and might as well give it a shot 🤘🤘

MadLittleMods commented 4 years ago

This is now part of v4.8.0

Going to wait for the prebuilds to build and publish to npm 🚀