fix(linux): segfault on close

MadLittleMods / node-usb-detection

List USB devices in system and detect changes on them.

MIT License

371 stars 114 forks source link

fix(linux): segfault on close #144

Closed sarakusha closed 2 years ago

sarakusha commented 3 years ago

On Linux, stopping or closing a program causes a segfault, since resources are freed before the thread terminates. Since this no longer affects the operation of the program, many did not notice this behavior.

sarakusha commented 3 years ago

I didn't notice that there is already fix #138 . I would still suggest my fix. Please do not postpone the update

MadLittleMods commented 2 years ago

@sarakusha Thanks for the contribution @sarakusha! Sorry for the delay 🙇‍♀️

There is a lot more context and explanation behind the changes in https://github.com/MadLittleMods/node-usb-detection/pull/138 so I'm going to close in favor of that one.

Feel free to reply over there, if you have some more insight 🙂