search

MadLittleMods / node-usb-detection

List USB devices in system and detect changes on them.
MIT License
371 stars 114 forks source link

Fix segfault crash after `stopMonitoring` on Linux v2 #162

Closed umbernhard closed 2 years ago

umbernhard commented 2 years ago

Fix https://github.com/MadLittleMods/node-usb-detection/issues/57

Keeps @antelle's contributions in tree from https://github.com/MadLittleMods/node-usb-detection/pull/138 and incorporates @MadLittleMods and @Julusian's requested changes (I think).

I've confirmed this still fixes the segfault issue on Debian 11/Node 12, but not much beyond that.

Furthermore, the tests don't all pass, but it appears they don't in the main repo either.

MadLittleMods commented 2 years ago

Thanks for the contribution @umbernhard! 😀

It will be part of the upcoming 4.14.0 release once I figure out why the Windows CI is broken, https://github.com/MadLittleMods/node-usb-detection/issues/164