Unbind ATL lib on Windows

MadLittleMods / node-usb-detection

List USB devices in system and detect changes on them.

MIT License

370 stars 114 forks source link

Unbind ATL lib on Windows #84

Closed sarakusha closed 4 years ago

sarakusha commented 5 years ago

windows-build-tools doesn't install ATL, so you can't compile this package until you install ATL manually.

sarakusha commented 5 years ago

I have already fixed the formatting of the code, how about commit PR.

MadLittleMods commented 5 years ago

Seems to build fine for me and ran the tests(npm test)

Windows 10
node@10.15.1 (node -v)
node-gyp@3.8.0 (node-gyp -v)
Python 2.7
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community (node-gyp configure --verbose)
- Microsoft.VisualStudio.Component.Windows10SDK.17763
- Microsoft.VisualStudio.Component.VC.Tools.x86.x64
- Microsoft.VisualStudio.VC.MSBuild.Base
- Using this installation with Windows 10 SDK

@sarakusha Have you ran through the tests on your machine? Can you share your environment details for reference?

pauloavelar commented 5 years ago

Sorry to jump in, but is there a timeline for this feature to be merged and released? I am currently benchmarking libraries for listing USB devices in Electron but don't want to add a full VS installation requirement. I can't build on Windows right now because my env lacks "atlstr.h", which I suppose this PR fixes.

webees commented 5 years ago

@pauloavelar use vs_buildtools__1891780700.1567674472.exe to check Visual C++ ATL.

I wasted four hours.../(ㄒoㄒ)/~~

MadLittleMods commented 4 years ago

Sorry for the delay 🥶

This fix is released in usb-detection@4.5.0 :tada:

Thanks for the fix @sarakusha ❤️