search

MadLittleMods / node-usb-detection

List USB devices in system and detect changes on them.
MIT License
370 stars 114 forks source link

Fix deprecation warnings for Nan::Callback:Call() #93

Closed kryops closed 4 years ago

MadLittleMods commented 4 years ago

Thanks for getting rid of this technical debt @kryops :+1:

Rebased on the latest master and tested on Windows 10 with Node.js v13.2.0 and Node.js v10.15.1

Before

$ npm run rebuild

> usb-detection@4.5.0 rebuild C:\Users\MLM\Documents\GitHub\node-usb-detection
> node-gyp rebuild

C:\Users\MLM\Documents\GitHub\node-usb-detection {git}{hg}
{lamb} if not defined npm_config_node_gyp (node "C:\Users\MLM\AppData\Roaming\nvm\v13.2.0\node_modules\npm\node_modules\npm-lifecycle\node-gyp-bin\\..\..\node_modules\node-gyp\bin\node-gyp.js" rebuild )  else (node "C:\Users\MLM\AppData\Roaming\nvm\v13.2.0\node_modules\npm\node_modules\node-gyp\bin\node-gyp.js" rebuild )
Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
  detection.cpp
  deviceList.cpp
  detection_win.cpp
  win_delay_load_hook.cc
c:\users\mlm\documents\github\node-usb-detection\src\detection.cpp(60): warning C4996: 'Nan::Callback::Call': was declared deprecated [C:\Users\MLM\Documents\GitHub\ node-usb-detection\build\detection.vcxproj]
  c:\users\mlm\documents\github\node-usb-detection\node_modules\nan\nan.h(1674): note: see declaration of 'Nan::Callback::Call'
c:\users\mlm\documents\github\node-usb-detection\src\detection.cpp(105): warning C4996: 'Nan::Callback::Call': was declared deprecated [C:\Users\MLM\Documents\GitHub \node-usb-detection\build\detection.vcxproj]
  c:\users\mlm\documents\github\node-usb-detection\node_modules\nan\nan.h(1674): note: see declaration of 'Nan::Callback::Call'
c:\users\mlm\documents\github\node-usb-detection\src\detection.cpp(195): warning C4996: 'Nan::Callback::Call': was declared deprecated [C:\Users\MLM\Documents\GitHub \node-usb-detection\build\detection.vcxproj]
  c:\users\mlm\documents\github\node-usb-detection\node_modules\nan\nan.h(1674): note: see declaration of 'Nan::Callback::Call'
     Creating library C:\Users\MLM\Documents\GitHub\node-usb-detection\build\Release\detection.lib and object C:\Users\MLM\Documents\GitHub\node-usb-detection\build\
  Release\detection.exp
  detection.vcxproj -> C:\Users\MLM\Documents\GitHub\node-usb-detection\build\Release\\detection.node

After

$ npm run rebuild

> usb-detection@4.6.0 rebuild C:\Users\MLM\Documents\GitHub\node-usb-detection
> node-gyp rebuild

C:\Users\MLM\Documents\GitHub\node-usb-detection {git}{hg}
{lamb} if not defined npm_config_node_gyp (node "C:\Users\MLM\AppData\Roaming\nvm\v13.2.0\node_modules\npm\node_modules\npm-lifecycle\node-gyp-bin\\..\..\node_modules\node-gyp\bin\node-gyp.js" rebuild )  else (node "C:\Users\MLM\AppData\Roaming\nvm\v13.2.0\node_modules\npm\node_modules\node-gyp\bin\node-gyp.js" rebuild )
Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
  detection.cpp
  deviceList.cpp
  detection_win.cpp
  win_delay_load_hook.cc
     Creating library C:\Users\MLM\Documents\GitHub\node-usb-detection\build\Release\detection.lib and object C:\Users\MLM\Documents\GitHub\node-usb-detection\build\
  Release\detection.exp
  detection.vcxproj -> C:\Users\MLM\Documents\GitHub\node-usb-detection\build\Release\\detection.node